BACKGROUND: There is a paucity of studies on comparison of quality of life (QOL) of type-1 and type-2 diabetes patients, and the impact of family caregivers' impressions on the QOL of patients. OBJECTIVES: To assess the subjective QOL of Sudanese diabetics using the WHOQOL-Bref, compared with a general population sample; examine caregiver-patient concordance; and assess the variables that impact on QOL. METHOD: The responses of 105 outpatients with type-1 diabetes and 136 with type-2 diabetes were compared with their family caregivers' impressions and 139 general population subjects. RESULTS: Patients were predominantly dissatisfied with their life circumstances. Type-1 diabetics had significantly lowest QOL scores, while the control group had highest scores. Having additional medical problems; having diminished sexual desire; and being young, unemployed and single were associated with poor QOL, but illness duration was not. Type-2 diabetics had lesser concordance with caregivers. The only predictor of patients' QOL was the caregivers' impression of patients' QOL. CONCLUSIONS: Caregivers' impression of patients' QOL impacted on outcome. Caregiver education is, therefore, important. The factors associated with QOL indicate a group that needs focused attention. The good QOL for type-2 and nonsignificance of illness duration encourage therapeutic optimism.